Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get-DbaDbFile: add Database ID #8175

Merged
merged 1 commit into from
Feb 20, 2022
Merged

Get-DbaDbFile: add Database ID #8175

merged 1 commit into from
Feb 20, 2022

Conversation

lancasteradam
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes Get-DbaDbFile add Database ID #8053 )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

Minor change to add Database ID to the output as requested in #8053

Approach

The database object is available at the end of the command so the ID is added into the return object.

Commands to test

New Pester tests are added to confirm that the database ID is returned.

andreasjordan
andreasjordan approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@andreasjordan andreasjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. But should we add the DatabaseID to the output of other commands as well?

@lancasteradam lancasteradam mentioned this pull request Feb 19, 2022
Closed
@lancasteradam
Copy link
Contributor Author

@andreasjordan, that is a great idea. I would suggest that be a separate PR or a series of PRs. I added an issue #8183 for the analysis to be done.

@potatoqualitee potatoqualitee merged commit bccf180 into dataplat:development Feb 20, 2022
@potatoqualitee
Copy link
Member

awesome, thank you both 🥳

@PowerDBAKlaas
Copy link
Member

Thanks @andreasjordan @lancasteradam !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasjordan andreasjordan andreasjordan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get-DbaDbFile add Database ID
4 participants
@lancasteradam @potatoqualitee @PowerDBAKlaas @andreasjordan