move cluster perms to Add-DbaAgReplica from New-DbaAvailabilityGroup #8181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasjordan
approved these changes
Feb 16, 2022
|
@potatoqualitee: Please do not release after merging this as we would like to address other issues discussed in #8178 as well and test them together in development before releasing. |
10 tasks
|
thanks for the note, @andreasjordan - i'll wait to merge after my questions have been addressed. |
|
The other issues are addressed in #8182, so now this here can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
.\tests\manual.pester.ps1)Purpose
Move the
NY AUTHORITY\SYSTEMpermissioning into the Add-DbaAgReplica command so that replicas added after the AG is created have the permissions on the system account required to failover/become primary.