Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get-DbaUserPermission - Refactoring again #8228

Merged
merged 8 commits into from
Mar 12, 2022

Conversation

andreasjordan
Copy link
Contributor

Like in #8220, but this time without introducing a bug.

@andreasjordan
Copy link
Contributor Author

Test should fail - just to see if test is effective.

Then I will fix the bug in the next commit.

@andreasjordan
Copy link
Contributor Author

Ok, Test works:
image

Now let's fix the bug....

@Stuart-Moore
Copy link
Contributor

That's fixed my issue 👍 (https://github.com/Stuart-Moore/sqlbitsdb1/runs/5520422771?check_suite_focus=true)

Thank you for sorting so quickly

@potatoqualitee
Copy link
Member

awesome, thank you both so much! thank you for the quick turnaround too, @andreasjordan 🙇🏼

@potatoqualitee potatoqualitee merged commit 2949838 into development Mar 12, 2022
@potatoqualitee potatoqualitee deleted the GetDbaUserPermission_refactor2 branch March 12, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants