Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/New-DbaComputerCertificate - Add Flag support #8353

Merged
merged 11 commits into from
May 17, 2022
Merged

Conversation

potatoqualitee
Copy link
Member

Now I understand more about certs 💯

Fixes #8245 and #8252

Tested successfully with the following commands:

New-DbaComputerCertificate -ComputerName sql01, sql02 -ClusterInstanceName deleteme -FriendlyName "Delete me" -Verbose -Flag NonExportable
 Add-DbaComputerCertificate -Path C:\temp\test.pfx -Confirm:$false -ComputerName sql01 -Verbose

I never did use the UserProtected flag. It pops this up.

image

Since that can only be accepted on localhost, I limited the flag usage to localhost.

@potatoqualitee
Copy link
Member Author

Integration tests pass ✅ Post PRs/reviews welcome. Seems not a lot of activity at this time so I'm rushing it a little along while I'm motivated.

@potatoqualitee potatoqualitee merged commit d74ef83 into development May 17, 2022
@potatoqualitee potatoqualitee deleted the fixcerts branch May 17, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add-DbaComputerCertificate - Private key missing
1 participant