Set-DbaDbCompression, prefer online rebuilds where possible #9118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read -- recent changes to our repo
On November 10, 2022, we removed some bloat from our repository (for the second and final time). This change requires that all contributors reclone or refork their repo.
PRs from repos that have not been recently reforked or recloned will be closed and @potatoqualitee will cherry-pick your commits and open a new PR with your changes.
Type of Change
.\tests\manual.pester.ps1
)Purpose
Try to do online operations where possible.
Approach
There's a swanky "IsOnlineRebuildSupported" on the index property to signal if the version supports online operations. Unfortunately, it's not on the database level.
So, we loop over existing indexes, and if one is found and IsOnlineRebuildSupported is true, we set the relevant flags on the rebuild operation.
Fixes:
there was a manual FIX due to a SMO bug for resetting tables to "None", but it seems to be fixed, so I removed the workaround from the codereintroduced, as it seems to be working on AZ but not onprem.Problems:
Possible problems: