Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup-DbaDatabase - allow users to specify no compression #9151

Merged

Conversation

ben-thul
Copy link
Contributor

@ben-thul ben-thul commented Nov 3, 2023

Please read -- recent changes to our repo

On November 10, 2022, we removed some bloat from our repository (for the second and final time). This change requires that all contributors reclone or refork their repo.

PRs from repos that have not been recently reforked or recloned will be closed and @potatoqualitee will cherry-pick your commits and open a new PR with your changes.

  • Please confirm you have the smaller repo (85MB .git directory vs 275MB or 110MB or 185MB .git directory)

Type of Change

  • Bug fix (non-breaking change, fixes Allow Backup-DbaDatabase to specify no backup compression #9150 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

Align -CompressBackup flag for Backup-DbaDatabase with analogous T-SQL options.

Approach

Allows user to specify -CompressBackup:$false to disable backup compression.

Commands to test

Backup-DbaDatabase with various values for -CompressBackup

Screenshots

image

@potatoqualitee
Copy link
Member

Looks fantastic and tests pass. Thank you, @ben-thul !

@potatoqualitee potatoqualitee merged commit 21aa6ff into dataplat:development Nov 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Backup-DbaDatabase to specify no backup compression
2 participants