Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke-DbaQuery, support reuse of parameters #9221

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

niphlod
Copy link
Contributor

@niphlod niphlod commented Jan 22, 2024

Please read -- recent changes to our repo

On November 10, 2022, we removed some bloat from our repository (for the second and final time). This change requires that all contributors reclone or refork their repo.

PRs from repos that have not been recently reforked or recloned will be closed and @potatoqualitee will cherry-pick your commits and open a new PR with your changes.

  • Please confirm you have the smaller repo (85MB .git directory vs 275MB or 110MB or 185MB .git directory)

Type of Change

  • Bug fix (non-breaking change, fixes SqlParameters are not cleared after Invoke-DbaAsync completes, preventing reuse of SqlParameter objects #9217 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

Allow to reuse parameters among multiple calls of invoke-dbaquery

Approach

Cleaning params just after query execution. BTW, this is the default behaviour of .NET, not something that dbatools did "wrong" . It's nice though to be able to reuse params if needed, so thanks for the original report

@potatoqualitee potatoqualitee merged commit 11b251a into dataplat:development Jan 24, 2024
3 checks passed
@potatoqualitee
Copy link
Member

thank you and thank you for the tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlParameters are not cleared after Invoke-DbaAsync completes, preventing reuse of SqlParameter objects
2 participants