Restore-DbaDatabase - improve warning output for standby mode databases #9230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the recovery logic to include databases in standby mode. Previously, the code only addressed databases in the restoring state, which did not account for standby scenarios. This change ensures a more comprehensive recovery process.
niphlod
requested changes
Jan 29, 2024
niphlod
approved these changes
Jan 29, 2024
wsmelton
requested changes
Feb 1, 2024
|
This is marked as being a bug fix, what bug issue is being addressed 😉 ? |
wsmelton
changed the title
Co-authored-by: Shawn Melton <11204251+wsmelton@users.noreply.github.com>
There doesn't appear to be a related issue; however, it's unable to recover standby database. |
|
@wsmelton - do you want an issue created to track this bug fix? or we good to merge? |
|
Merging due to Niph's approval since it's been a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the recovery logic to include databases in standby mode. Previously, the code only addressed databases in the restoring state, which did not account for standby scenarios. This change ensures a more comprehensive recovery process.
Please read -- recent changes to our repo
On November 10, 2022, we removed some bloat from our repository (for the second and final time). This change requires that all contributors reclone or refork their repo.
PRs from repos that have not been recently reforked or recloned will be closed and @potatoqualitee will cherry-pick your commits and open a new PR with your changes.
Type of Change
.\tests\manual.pester.ps1)