Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Get-DbaWaitStatistic.ps1 to be in sync with the Paul Randal script it copies from (fixes 9251) #9249

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

ReeceGoding
Copy link
Contributor

@ReeceGoding ReeceGoding commented Feb 16, 2024

This fixes issue #9251.

Please read -- recent changes to our repo

On November 10, 2022, we removed some bloat from our repository (for the second and final time). This change requires that all contributors reclone or refork their repo.

PRs from repos that have not been recently reforked or recloned will be closed and @potatoqualitee will cherry-pick your commits and open a new PR with your changes.

  • Please confirm you have the smaller repo (85MB .git directory vs 275MB or 110MB or 185MB .git directory)

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes Get-DbaWaitStatistic is three years behind the Paul Randall script it copies #9251 )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Added SOS_WORK_DISPATCHER to the Ignorable list.
Added PWAIT_EXTENSIBILITY_CLEANUP_TASK to the ignore list. https://www.sqlskills.com/help/waits/pwait_extensibility_cleanup_task/ documents it as benign.
Added extra missing waits and (mostly useless) categories. This puts us up to date with the October 1, 2021 script found at https://www.sqlskills.com/blogs/paul/wait-statistics-or-please-tell-me-where-it-hurts/
Removed duplicate hash.
@ReeceGoding ReeceGoding changed the title Update Get-DbaWaitStatistic.ps1 To Filter Out SOS_WORK_DISPATCHER By Default (Fixes #9248) Update Get-DbaWaitStatistic.ps1 to be in Sync with the Paul Randal script it copies from (fixes 9251) Feb 19, 2024
@ReeceGoding ReeceGoding changed the title Update Get-DbaWaitStatistic.ps1 to be in Sync with the Paul Randal script it copies from (fixes 9251) Update Get-DbaWaitStatistic.ps1 to be in sync with the Paul Randal script it copies from (fixes 9251) Feb 19, 2024
@jpomfret jpomfret merged commit e13f779 into dataplat:development Feb 21, 2024
1 check passed
@jpomfret
Copy link
Collaborator

Makes sense to me - thank you @ReeceGoding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get-DbaWaitStatistic is three years behind the Paul Randall script it copies
2 participants