Install-DbaMaintenanceSolution does not work inside a container #9252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read -- recent changes to our repo
On November 10, 2022, we removed some bloat from our repository (for the second and final time). This change requires that all contributors reclone or refork their repo.
PRs from repos that have not been recently reforked or recloned will be closed and @potatoqualitee will cherry-pick your commits and open a new PR with your changes.
Type of Change
[X] Bug fix (non-breaking change, fixes # )
Purpose
Fix internet connection check inside windows containers
Approach
Remove uneeded internet connection check prior to download attempt. Current implementation already does fallback to embedded maintenance solution if download fails, so there is no need pre-check.
Inside a windows container, see output of current commands used to pre-check if an internet connection is available.
Commands to test
Install-DbaMaintenanceSolution
Screenshots
Learning