Update-ServiceStatus - fix cross-domain issue by changing ComputerName to PSComputerName #9288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running commands from a server connected to domainA to a computer running on domainB, the short name is used as documented on dataplat#9184. This is my attempt to get this change moving forward as the issue conversation has been quiet.
potatoqualitee
changed the title
|
Thank you! Fix looks interesting. Let's see if we can get these tests to pass. hopefully it was an issue with the runner and not the change. |
|
This fix seems reasonable. Thank you for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running commands from a server connected to domainA to a computer running on domainB, the short name is used as documented on #9184. This is my attempt to get this change moving forward as the issue conversation has been quiet.
Type of Change
.\tests\manual.pester.ps1)Purpose
Approach
Commands to test
Screenshots
Learning