This repository has been archived by the owner on Mar 1, 2018. It is now read-only.
Made irregular companies classifier tests more explicit #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 20f0643 on rennerocha:renne-irregular-companies-test into ** on datasciencebr:master**. |
|
Hi @rennerocha I was testing your PR and got lost for a while, sorry for that. So, first I'll fix issue #63 to better run the project, and then get back to you PR, sorry for not testing it yet, soon I'll be back with news! |
|
Any chance we follow the structure put forward by #78 here? We could add in the fixture the expected result. This sounds pretty cleaver, readable, maintainable and useful ; ) |
|
I'll work on that now @cuducos 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have few test cases in the related fixture, so it could be better to have these tests more explicit on their objectives, avoiding the developer to navigate between two files to understand the test.
As the test file remains smaller than 100 lines I believe we can remove the fixture.