Updates quota limit for car renting #86
Conversation
pedrovereza
force-pushed
the
car-renting-quota
branch
2 times, most recently
from
14d148f
to
382c89d
Compare
|
Hi @pedrovereza great PR! I have a question though: For those reimbursements from before the new definition shouldn't we have a monthly limit still somewhere in the code? I don't think the new quota value also applies to "before monthly limit increase". @cuducos @anaschwendler what you guys think? and better yet how to properly insert this piece of information on the code? |
There was a problem hiding this comment.
Many thanks for the PR Pedro.
I agree with @jtemporal: We do not delete the old limit — as we filter cases by dates, we can use the current limit for reimbursements from mid-2017 and on, and the old limit for the period when that limit was still in use. Does that make sense? Cheers
pedrovereza
force-pushed
the
car-renting-quota
branch
2 times, most recently
from
e08da36
to
bdcf372
Compare
pedrovereza
force-pushed
the
car-renting-quota
branch
2 times, most recently
from
e7d3ad5
to
6a5a1e3
Compare
pedrovereza
force-pushed
the
car-renting-quota
branch
from
6a5a1e3
to
470da94
Compare
|
@jtemporal @cuducos Hey, thanks for the feedback! The change requested totally makes sense, and I think I got it right now 😉 |
| @@ -18,15 +18,15 @@ def setUp(self): | |||
|
|
|||
| def test_predict_false_when_not_in_date_range(self): | |||
| assert_array_equal(np.repeat(False, 10), | |||
| self.prediction[[0, 1, 9, 10, 18, 19, 27, 28, 36, 37]]) | |||
| self.prediction[[0, 1, 18, 19, 27, 28, 36, 37, 45, 46]]) | |||
There was a problem hiding this comment.
Quick note here: car renting before 07/2017 is not really out of range as it falls into the previous period (04/2015 - 06/2017)
|
Yay, many thanks, @pedrovereza : ) Great contribution o/ |
Fixes #62
New quota was defined as R$ 12.713,00.