This repository has been archived by the owner on Sep 18, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if this is the best method to have it. Since for now is not needed, droping it from the codebase.
Not yet ready to the world
We tested for a few days, but user acceptance wasn't good enough to keep it active.
Irio
force-pushed
the
irio-facebook-messenger
branch
from
September 9, 2017 15:16
f999249
to
243bc8b
Compare
cuducos
reviewed
Sep 11, 2017
docker-compose.yml
Outdated
# environment: | ||
# - FLASK_APP=server.py | ||
# - MONGO_DATABASE=whistleblower | ||
# - MONGO_URL=mongodb://mongo:27017/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this commented block committed? Apart from that LGTM. LMK what do you think and I merge this branch ; )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just out of interest of releasing the code... would merge and open an issue to remove the comments...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed as you asked.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has been running this branch for a few days.
Don't be afraid of reviewing it. It includes code to integrate Facebook Messenger, which was already removed it. Would like to keep a commit for it so we can rollback in the future if we wish so.