Skip to content
This repository has been archived by the owner on Sep 18, 2018. It is now read-only.

Make code ready to Digital Ocean #12

Merged
merged 36 commits into from
Nov 4, 2017
Merged

Make code ready to Digital Ocean #12

merged 36 commits into from
Nov 4, 2017

Conversation

Irio
Copy link
Collaborator

@Irio Irio commented Jul 25, 2017

Has been running this branch for a few days.

Don't be afraid of reviewing it. It includes code to integrate Facebook Messenger, which was already removed it. Would like to keep a commit for it so we can rollback in the future if we wish so.

Not sure if this is the best method to have it.
Since for now is not needed, droping it from the codebase.
Not yet ready to the world
We tested for a few days, but user acceptance wasn't
good enough to keep it active.
@coveralls
Copy link

Coverage Status

Coverage increased (+43.4%) to 81.622% when pulling 243bc8b on irio-facebook-messenger into acd5deb on master.

# environment:
# - FLASK_APP=server.py
# - MONGO_DATABASE=whistleblower
# - MONGO_URL=mongodb://mongo:27017/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this commented block committed? Apart from that LGTM. LMK what do you think and I merge this branch ; )

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just out of interest of releasing the code... would merge and open an issue to remove the comments...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed as you asked.

@Irio Irio merged commit 8f3f915 into master Nov 4, 2017
@Irio Irio deleted the irio-facebook-messenger branch November 4, 2017 01:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants