This repository has been archived by the owner on Nov 28, 2023. It is now read-only.
New: auto-detect which network interface to bridge VirtualBox on #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartherbert
added a commit
that referenced
this pull request
Aug 4, 2014
New: auto-detect which network interface to bridge VirtualBox on
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a mixed-OS environment (e.g. a mix of Ubuntu and OSX machines), the :bridge setting in Vagrantfiles has always been a pain. There's no one setting that works equally well on multiple platforms. Until now, we've dealt with it by showing the user when Vagrant prompts for a network interface. Thanks to the recent 'silent-subprocesses' patch, that's no longer a good idea.
Turns out that we can ask Virtualbox for a list of interfaces that are bridgeable. This PR does exactly that, and assumes that we want to bridge onto the first interface we find with an IPv4 address. (We will be tackling IPv6 support separately, and very soon). We set the environment variable VAGRANT_BRIDGE_ADAPTER to the interface that we choose, and you can use this variable inside your Vagrantfiles.