Add additionalServiceOptions #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or annotations to generated services
burmanm
requested review from
bradfordcp,
jimdickinson,
johntrimble,
respringer and
sandoichi
as code owners
jsanda
requested changes
Mar 9, 2021
jsanda
requested changes
Mar 9, 2021
operator/pkg/apis/cassandra/v1beta1/cassandradatacenter_types.go
Outdated
Show resolved
Hide resolved
jsanda
reviewed
Mar 10, 2021
jsanda
approved these changes
Mar 10, 2021
| @@ -181,6 +181,9 @@ type CassandraDatacenterSpec struct { | |||
|
|
|||
| // Container image for the log tailing sidecar container. | |||
| SystemLoggerImage string `json:"systemLoggerImage,omitempty"` | |||
|
|
|||
| // AdditionalServiceConfig allows to define additional parameters that are included in the created Services. Note, user can override values set by cass-operator and doing so could break cass-operator functionality. | |||
There was a problem hiding this comment.
👍 , but we'll probably have to document which labels they should avoid, somewhere
There was a problem hiding this comment.
@burmanm can you document the labels that need to be avoided? I think there are only a handful, in which case maybe just list them in the comments here.
jimdickinson
approved these changes
Mar 10, 2021
jsanda
requested changes
Mar 26, 2021
| @@ -181,6 +181,9 @@ type CassandraDatacenterSpec struct { | |||
|
|
|||
| // Container image for the log tailing sidecar container. | |||
| SystemLoggerImage string `json:"systemLoggerImage,omitempty"` | |||
|
|
|||
| // AdditionalServiceConfig allows to define additional parameters that are included in the created Services. Note, user can override values set by cass-operator and doing so could break cass-operator functionality. | |||
There was a problem hiding this comment.
@burmanm can you document the labels that need to be avoided? I think there are only a handful, in which case maybe just list them in the comments here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows defining additional labels and/or annotations to generated services. At the moment it only creates it to the main-service (--service) - do we want the same replicated to cluster2-seed-service and cluster2-dc2-all-pods-service as well ?
Fixes #293 and k8ssandra/k8ssandra#478