[#3336] improvement(test): make docker detection failure error messages more clear #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
approved these changes
May 24, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 24, 2024
…es more clear (#3538) ### What changes were proposed in this pull request? - clarify OrbStack status - check the docker env before IT start ### Why are the changes needed? The previous detection logic was located in the constructor, and when the test failed, it would throw an exception `ExceptionInInitializerError`, causing the original error to be covered. Fix: #3336 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? Locally, by hand
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…messages more clear (apache#3538) ### What changes were proposed in this pull request? - clarify OrbStack status - check the docker env before IT start ### Why are the changes needed? The previous detection logic was located in the constructor, and when the test failed, it would throw an exception `ExceptionInInitializerError`, causing the original error to be covered. Fix: apache#3336 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? Locally, by hand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
The previous detection logic was located in the constructor, and when the test failed, it would throw an exception
ExceptionInInitializerError, causing the original error to be covered.Fix: #3336
Does this PR introduce any user-facing change?
no
How was this patch tested?
Locally, by hand