[#3856] feat(core): Support embedded JDBC storage backend #3922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lw-yang
reviewed
Jun 24, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/EmbeddedJDBCBackend.java
Outdated
Show resolved
Hide resolved
mchades
reviewed
Jun 24, 2024
jerryshao
reviewed
Jun 26, 2024
| .create(); | ||
|
|
||
| public static final ConfigEntry<String> ENTRY_RELATIONAL_JDBC_BACKEND_PATH = |
There was a problem hiding this comment.
Is it "ENTRY" or "ENTITY" here?
jerryshao
reviewed
Jun 26, 2024
jerryshao
reviewed
Jun 26, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/JDBCBackend.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jun 26, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/JDBCBackend.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jun 26, 2024
| } | ||
| } | ||
|
|
||
| private static void initH2Backend( |
There was a problem hiding this comment.
I would suggest you have new class to handle H2 related initialization things, not doing these here. Also to see if you can refactor to avoid using switch case here.
There was a problem hiding this comment.
Done, if you have time, please take another look.
jerryshao
reviewed
Jun 26, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/JDBCDatabase.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jun 26, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/backend/H2Database.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jun 26, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/backend/H2Database.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jun 26, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/backend/H2Database.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jun 27, 2024
| @@ -66,6 +69,17 @@ private Configs() {} | |||
| public static final String DEFAULT_KV_ROCKSDB_BACKEND_PATH = | |||
| String.join(File.separator, System.getenv("GRAVITINO_HOME"), "data", "rocksdb"); | |||
|
|
|||
| public static final String DEFAULT_RELATIONAL_JDBC_BACKEND_PATH = | |||
| String.join(File.separator, System.getenv("GRAVITINO_HOME"), "data", "jdbc"); | |||
There was a problem hiding this comment.
Is it better to use "h2" not "jdbc" for db path?
There was a problem hiding this comment.
I'm not very sure h2 is a good name for the directory name as it's the default value of all JDBC database, assuming we are using SQLite as the database backend and using the default backend path, so the name is still h2, it's very puzzling.
jerryshao
reviewed
Jun 27, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/backend/H2Database.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jun 27, 2024
jerryshao
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add support for an embedded JDBC storage backend.
Why are the changes needed?
We plan to replace RocksDB KV backend with an embedded JDBC backend as the default storage backend.
Fix: #3856
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Existing UT