Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover all kinds of TABLE (seed, model, source, snapshot), currently supports only resource_type=model #3

Closed
datnguye opened this issue Dec 20, 2022 · 4 comments
Closed

Cover all kinds of TABLE (seed, model, source, snapshot), currently supports only resource_type=model #3

datnguye opened this issue Dec 20, 2022 · 4 comments

Comments

@datnguye
Copy link
Owner

No description provided.

@datnguye
Copy link
Owner Author

Only models are make sense to be in ERD

@yingyingqiqi
Copy link
Contributor

@datnguye ，Why" Only models are make sense to be in ERD ", I want to give an example. All our raw layer data is saved to S3 and corresponding external tables are created in Snowflake. Shouldn't we also add resource_type = source to the ERD?

@il-dat
Copy link
Contributor

il-dat commented Mar 29, 2023

@yingyingqiqi You are reason. There is a need for source there. Thanks for raising it. Would you be able to create a new issue for that? (I am not sure how to re-open this)
And you are more welcome to contribute the PR for it 👍, I will work on it once getting the chance. Cheers

@yingyingqiqi yingyingqiqi mentioned this issue Mar 29, 2023
Closed
@yingyingqiqi
Copy link
Contributor

cc: @il-dat , #13
thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@datnguye @yingyingqiqi @il-dat