Merge v2 into main #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eea5b9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…into update-tests
Update tests
olayway
requested changes
Nov 22, 2023
There was a problem hiding this comment.
LGTM! Just some minor fixes needed:
- make sure only
![]()common mark image embeds and![[]]Obsidian embeds haveembed: trueset (and adjust any tests)
2) add expect forurl_pathin process.spec - Uncomment tests related to parsing Obsidian wiki links and make sure these pass too
Update obsidian links test
olayway
approved these changes
Nov 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Tags Extraction from Markdown Content.
Resolved issues with link extraction from Markdown documents.
Conducted code refactoring for improved readability and maintainability.