Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ #58 , refactor mddb code to use ] #59

Merged
merged 3 commits into from
Nov 21, 2023
Merged

[ #58 , refactor mddb code to use ] #59

merged 3 commits into from
Nov 21, 2023

Conversation

mohamedsalem401
Copy link
Contributor

indexFolder function that takes a folderPath and returns File objects.
Refactor the code in markdown.ts to use the new function instead.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: cb40cc3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mohamedsalem401 mohamedsalem401 changed the base branch from main to v2 November 20, 2023 15:21
olayway
olayway approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@olayway olayway left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👏

As for versioning: since we already merged a few other PRs without changeset files, it would be good to create one that would describe changes made in all of them. So either add such a file in this PR and remember to mention all these changes in the description, or merge this one without a changeset and add one separately, directly onto the main branch.

src/lib/markdowndb.ts
// @ts-ignore
await MddbTag.batchInsert(this.db, tagsToInsert);
await MddbFileTag.batchInsert(this.db, fileTagsToInsert);
await MddbLink.batchInsert(this.db, getUniqueValues(linksToInsert));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use getUniqueValues earlier? Like you did for tags. Or the other way round, just be consistent.

@mohamedsalem401 mohamedsalem401 merged commit 26a7164 into v2 Nov 21, 2023
@mohamedsalem401 mohamedsalem401 deleted the refactor-2 branch November 21, 2023 13:39
@mohamedsalem401 mohamedsalem401 mentioned this pull request Nov 21, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olayway olayway olayway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohamedsalem401 @olayway