Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ng-entity-service): make methods protected to prevent error for e… #430

Merged
merged 1 commit into from
May 20, 2020

Conversation

rosostolato
Copy link
Contributor

…xtended classes

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

akita-ng-odata-service extends NgEntityService and tries to use private methods that are causing issues on latest TS version.

Issue Number: akita-ng-odata-service #1

What is the new behavior?

changed private methods to protected

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@NetanelBasal NetanelBasal merged commit aaef238 into salesforce:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants