Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data aggregator doesn't have keys method #35

Closed
richardjgowers opened this issue Jul 1, 2015 · 1 comment
Closed

Data aggregator doesn't have keys method #35

richardjgowers opened this issue Jul 1, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@richardjgowers
Copy link
Contributor

Sim.selections.keys() # works
Sim.categories.keys() # works

# but
Sim.data.keys() # doesn't work
Sim.universes.keys() # doesn't work

If I'm using a dict like object, it makes sense to have a keys method for this. I had a quick look through the code, and it looks like the data aggregator is different, but ideally it should behave like the others? Maybe link keys to data._list?

@dotsdl
Copy link
Member

dotsdl commented Jul 1, 2015

Agreed. Originally I was wary of making aggregators look too much like dicts lest they be expected to behave like dicts in every way, since not every method available for dicts makes sense for these objects. I've since changed my mind, at least with respect to keys; the other aggregators reflect this, but I missed doing it for Data. I'll add a keys method to the Data aggregator.

@dotsdl dotsdl added this to the 0.5.1 milestone Jul 1, 2015
@dotsdl dotsdl added the bug label Jul 1, 2015
@dotsdl dotsdl self-assigned this Jul 1, 2015
@dotsdl dotsdl closed this as completed in 24e1fe7 Jul 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants