Bad Substitution

[polyrtm]

When I run the install.sh file, I get an error.

./install.sh: line 3: ${${XDG_DATA_HOME}:-${HOME}/.local/share}: bad substitution

[carnager]

can't reproduce:

carnager@caprica ~ > xdg=${${XDG_DATA_HOME}:-${HOME}/.local/share}
carnager@caprica ~ > echo "${xdg}"
/home/carnager/.local/share

[Kabouik]

Same issue for me.

mathieu@xiaomimi-solus ~/.config/rofi-themes $ xdg=${${XDG_DATA_HOME}:-${HOME}/.local/share}
bash: ${${XDG_DATA_HOME}:-${HOME}/.local/share}: bad substitution

This is dirty, but just replacing the corresponding line in install.sh fixed the issue for me:

#!/usr/bin/env bash

xdg=${HOME}/.local/share
DIRECTORY="${xdg}/rofi/themes/"

if [ ! -d "${DIRECTORY}" ]
then
    echo "Creating theme directory: ${DIRECTORY}"
    mkdir -p "${DIRECTORY}"
fi

declare -i ia=0
for themefile in **/*.rasi 
do
    if [ -f "${themefile}" ] && [ ${ia} -eq 0 ]
    then
        echo "Theme '${themefile}' exists, overwrite? y/N/a(ll)"
        read answer
        if [ x$answer = x"y" ]
        then
            echo "+Installing '${themefile}'"
            install "${themefile}" "${DIRECTORY}"
        elif [ x${answer} = x"a" ]
        then
            ia=1
            echo "+Installing '${themefile}'"
            install "${themefile}" "${DIRECTORY}"
        else
            echo "+Skipping ${themefile}"
        fi 
    else
            echo "+Installing '${themefile}'"
            install "${themefile}" "${DIRECTORY}"
    fi
done

Not that there was an issue with DIRECTORY="${xdg}/rofi/themes/"}, the last } was not opened before I think. Removing it seems to work.