Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UglifyJS #17

Open
pjebs opened this issue Nov 14, 2018 · 4 comments
Open

UglifyJS #17

pjebs opened this issue Nov 14, 2018 · 4 comments

Comments

@pjebs
Copy link

pjebs commented Nov 14, 2018

It would be great if you run uglify/ugllify2 afterwards to further minimize file size.

@dave
Copy link
Owner

dave commented Nov 14, 2018

Thanks for the suggestion! However, in jsgo everything runs in the Go process, so without a Go version of uglify this wouldn't be possible.

@dave
Copy link
Owner

dave commented Nov 14, 2018

BTW did you run any tests to see what percentage compression uglify gives? GopherJS has it's own minify routine which probably isn't as good as uglify but I wouldn't think the difference is that great...

@pjebs
Copy link
Author

pjebs commented Nov 14, 2018

I remember doing a comparison 5-6 months ago and uglification created serious improvements to size (non-negligible).

I think a docker based solution is the way to go if you want to run uglify as easily as possible.

@dave
Copy link
Owner

dave commented Nov 14, 2018

Adding this to the jsgo compiler would be a huge undertaking. Right now everything runs inside a single Go process - that keeps the architecture very simple. Adding docker as a dependency would make things much more complex.

Also, I'm working on other projects now, so won't have any more time for new jsgo features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants