Crash when manually defining file encoding

[xanderdunn]

I get an EXC_BAD_ACCESS crash when I use this:

NSInputStream *inputStream = [[NSInputStream alloc]
                                initWithFileAtPath:csvFilePath];
CHCSVParser *parser = [[CHCSVParser alloc]
                         initWithInputStream:inputStream
                         usedEncoding:NSUTF8StringEncoding
                         delimiter:','];

The crash occurs at line 119 of CHCSVParser.m, which is if (encoding == NULL || *encoding == 0) {

I am running all of this off the main thread, but I suspect that ought to be fine. Everything works fine off the main thread when I use initWithContentsOfCSVFile instead of the above.

My CHCSVParser.h/m are identical to GitHub's current master :head with the exception that I have included the code from #33, which simply provides a toggle for whitespace stripping and should have no effect on this.

I will upload the CSV file I am using and post a link as soon as possible. However, I don't think this error should be at all related to the CSV file, should it?

[davedelong]

Instead of:

CHCSVParser *parser = [[CHCSVParser alloc]
                     initWithInputStream:inputStream
                     usedEncoding:NSUTF8StringEncoding
                     delimiter:','];

You should be doing:

NSString encoding = NSUTF8StringEncoding;
CHCSVParser *parser = [[CHCSVParser alloc]
                     initWithInputStream:inputStream
                     usedEncoding:&encoding
                     delimiter:','];

Yeah, it's kind of weird, sorry. I didn't want an explosion of initializers, so if you know the encoding before-hand, it needs to be passed by-ref.

[xanderdunn]

That worked. Thanks. Definitely include this in the README and CHCSVParser.h.