Review issue: functionality

[andytwoods]

As per openjournals/joss-reviews#1044 Functionality, functionality.

on windows, in chrome, I couldn't undo via control-z.

[davekinkead]

Thanks for the bug report @andytwoods

I can't reproduce the problem on my setup but the relevant code is here

reasons/lib/ui.js

Lines 138 to 140 in 3c063b7

	if (
	(event.metaKey || Keycode.isEventKey(event, 'control') || Keycode.isEventKey(event, 'command'))
	&& Keycode.isEventKey(event, 'z')) {

Cmd + z, Ctrl + z, or the browser specific metakey + z should all work. I'll try to find a windows machine with chrome shortly.

In the mean time, can you please try the following http://www.reasons.io/maps/e25636f to see if the issue is browser or environment caused.

[davekinkead]

@andytwoods could you also please visit https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/metaKey and see if you can get metaKey = true in the example

[andytwoods]

I'm a reviewer for your submission to joss. I don't use your software. Not sure it's fair I am also involved in the debug process. Just use VirtualBox to check out the issue?

[davekinkead]

Quick update - I'm currently at a few conferences and will address this later this month when I'm back

[davekinkead]

Sorry for the delay. I was unable to reproduce the issue on a VirtualBox and have only just had access to a windows machine. ctrl z and ctrl y now work and I've manually tested windows 10 + chrome & windows 10 + firefox.