Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Upgrading Aruba in GLI #294

Closed
luke-hill opened this issue Nov 1, 2019 · 3 comments
Closed

Discussion: Upgrading Aruba in GLI #294

luke-hill opened this issue Nov 1, 2019 · 3 comments

Comments

@luke-hill
Copy link

Hi there,

I was wondering if we could discuss trying to bump the version of aruba currently in use in gli

Ideally first bumping to 0.8.0 and then to 0.14.9, from there supporting the latest 0.x version.

The reason is that we're trying to get all gems which are large and using aruba using a 0.14.x version where a lot of the bugfix and deprecation PR's are going in. As we're looking to release 1.0 of aruba in the near future.

If you could have a stab or let us know what we can do to help that would be great. It might be that the upgrade works flawlessly, if so that's awesome.

Try 0.8.0 and then 0.14.9 as the first two static upgrades would be my advice. Any other queries ask away I'll try help

Luke

@davetron5000
Copy link
Owner

Hey. Yeah, I have tried this a few times over the years (!). The main issue is that Aruba seems to have changed how it sets the path for executing commands and for whatever reason it's incompatible with GLI and I could not make it work.

I just tried to update to 0.8.0 and this is the issue I hit. I'm sure it's fixable, but I haven't had time to work with it.

@luke-hill
Copy link
Author

That's fine. If there's a PR or something where I can view failures I can try co-operate e.t.c. Or if you enable me to have push privileges to a branch I can try do something.

Happy to help, just not sure where I need to do whatever

@davetron5000
Copy link
Owner

I have removed aruba in favor of integration tests. They don't cover as much as the aruba ones but I think they will make it easier to maintain this app with one less dependency. See #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants