Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Windows #46

Open
stevenvachon opened this issue Jun 22, 2017 · 6 comments
Open

Test on Windows #46

stevenvachon opened this issue Jun 22, 2017 · 6 comments

Comments

@stevenvachon
Copy link
Contributor

stevenvachon commented Jun 22, 2017

…with AppVeyor. If you set up the [free] account, I can upload the config file.

@davglass
Copy link
Owner

I'm not opposed to adding this, I'm not a Windows user so I would be able to even fix issues if the build were to break.

@davglass
Copy link
Owner

Added the AppVeyor build info..

@davglass
Copy link
Owner

It's building now & the build fails (which we knew) but it's ready to be tested on.

@stevenvachon
Copy link
Contributor Author

I didn't know that it failed on Windows. Why are we using "jenkins-mocha"? I'd think that regular mocha would be sufficient.

Also, the AppVeyor config file could benefit from additional options: https://github.com/stevenvachon/edit-dotenv/blob/master/.appveyor.yml

@davglass
Copy link
Owner

jenkins-mocha wraps mocha which istanbul and provides coverage in a single command. Not sure why it's not working as I'm not a Windows user. Feel free to send a PR with the proper configs, I've never used Appveyor before and have no idea how it works and little time to explore all the options.

@stevenvachon
Copy link
Contributor Author

stevenvachon commented Jul 10, 2017

nyc (the all-in-one istanbul CLI) wraps mocha simply:

nyc mocha test.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants