Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendition 2 of getDescendantsByClassName has wrong logic #135

Closed
nearstate opened this issue Nov 2, 2012 · 1 comment
Closed

Rendition 2 of getDescendantsByClassName has wrong logic #135

nearstate opened this issue Nov 2, 2012 · 1 comment

Comments

@nearstate
Copy link
Contributor

Does not return descendants of the supplied element.

Please verify:

12: var elements = getDescendantsByTagName(document, '*')

should read

12: var elements = getDescendantsByTagName((el || document), '*')
@david-mark
Copy link
Member

Looks like a mistake was made there. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants