-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: warden vnc
to connect with Selenium Debug VNC
#116
Feature: warden vnc
to connect with Selenium Debug VNC
#116
Conversation
I've added multi-node and different types support: |
I've integrated the latest origin/develop into this PR and updated the messaging to use the new messaging functions, as well as tweaking a few details so they're compatible with latest 0.6.0 develop branch. The following is what I'd like to see happen for this to be merged: Since Warden is not Linux specific I would prefer to not adopt commands as 1st class citizens unless they are interoperable between both OS's. With Remina not supporting Mac OS, this command needs to do something to support Mac OS apart from using Remina. Even a graceful fallback would be acceptable, as long as it's mentioned in the documentation page. For example, the ssh tunnel currently mentioned in the docs page for use on OS X would suffice if the command printed out connection details for the user, and then started the ssh tunnel (preferably in the foreground so the user can Control + C to kill it):
On linux environments, the command could print a warning (using the I'd also like to see a |
Version when no Remmina installed That is based on RFC7869 https://tools.ietf.org/html/rfc7869 |
e40ddbc
to
732f8b4
Compare
3ac9ce0
to
5fe7c40
Compare
I've introduced a new Warden command that enables developer to connect VNC using
remmina
:Additionally, documentation extended with such information.
PS: @davidalger I added Color Reset after each Error message.