Change all :delegated mounts to :cached mounts to preserve existing behavior of mounts #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ehavior of mounts Reference https://docs.docker.com/docker-for-mac/mutagen/, docker/for-mac#1592. docker/for-mac#4590 for details. As of Docker Desktop Edge 2.3.2.0 the :delegated flag on a shared volume will automatically enable synchronization (via Mutagen) dramatically changing the expected and natural behavior of currently delegated mounts. Warden is currently using delegated mounts to specifically mount into containers things which should not be synced via Mutagen too avoid a performance penalty (large quantities of media files) and as a default for mount on Mac OS systems for better default performance characteristics where Mutagen syncs are not implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all
:delegatedusages in docker-compose configuration files to:cachedwhich currently functions identically to:delegatedand has been noted as the BC way to preserve existing behavior of delegated mounts when the new Mutagen based:delegatedimplementation reaches the stable channel.Reference https://docs.docker.com/docker-for-mac/mutagen/, docker/for-mac#1592. docker/for-mac#4590 for details. As of Docker Desktop Edge 2.3.2.0 the
:delegatedflag on a shared volume will automatically enable synchronization (via Mutagen) dramatically changing the expected and natural behavior of currently delegated mounts. Warden is currently using delegated mounts to specifically mount into containers things which should not be synced via Mutagen too avoid a performance penalty (large quantities of media files) and as a default for mount on Mac OS systems for better default performance characteristics where Mutagen syncs are not implemented.Given that
:cachedand:delegatedapparently have identical implementations currently (despite Docker documentation making a distinction) the use of:cachedwill not functionally change anything but will allow Warden to be forward compatible with changes seen on the horizon on Docker Desktop Edge channel.