Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xdebug3 support as separate image type #279

Merged
merged 3 commits into from
Jan 18, 2021
Merged

Add xdebug3 support as separate image type #279

merged 3 commits into from
Jan 18, 2021

Conversation

Den4ik
Copy link

@Den4ik Den4ik commented Dec 22, 2020

Description
This PR provide support of xdebug3 as separate images that can be configured in .env file by PHP_XDEBUG_3=1 directive

Related Issue
#267

@ihor-sviziev
Copy link
Contributor

@davidalger could you check it?

@davidalger
Copy link
Collaborator

Looks really good. I'm going to build these and give it a run. Since it's opt-in, I'm not too concerned with it breaking anyone's workflows. Good call on adding a feature flag for it. Perhaps sometime it can be removed and this go Xdebug 3 by default once it's stable and accepted by many.

As Xdebug 3 is only available for PHP 7.2+ the image build tooling will need to be updated to only build the xdebug3 variant for 7.2 and higher. I'm working on addressing this now It'd_ be simpler if the images were simply updated to install xdebug3 when php version supports it, but that would require everyone start using it right away, which we don't want here for now.

@davidalger
Copy link
Collaborator

Updated the build script so it should pass muster when this is merged (not attempting to build xdebug3 images on older versions of PHP) and then ran this on a local builder:

export PHP_VERSION=7.4 \
  && ./images/scripts/build.sh --push php-fpm/xdebug3 \
  && ./images/scripts/build.sh --push php-fpm/magento1/xdebug3 \
  && ./images/scripts/build.sh --push php-fpm/magento2/xdebug3

The following images are now available on docker hub so this can be tested:

wardenenv/php-fpm:7.4-xdebug3
wardenenv/php-fpm:7.4-magento1-xdebug3
wardenenv/php-fpm:7.4-magento2-xdebug3

Once merged the rest should build via CI.

@davidalger davidalger linked an issue Jan 18, 2021 that may be closed by this pull request
@davidalger
Copy link
Collaborator

davidalger commented Jan 18, 2021

Spun up a 2.4.2 sandbox running PHP 7.4, verified requests work and would stop on a breakpoint with and without PHP_XDEBUG_3=1 using VSCode on ports 9000 (Xdebug 2) and 9003 (Xdebug 3) with success in both cases. Going to merge this, and hopefully tag a release sometime this week. Thanks!

@davidalger davidalger merged commit 56a55d1 into wardenenv:develop Jan 18, 2021
davidalger added a commit that referenced this pull request Jan 18, 2021
@Den4ik Den4ik deleted the xdebug3-support branch January 18, 2021 05:42
@davidalger davidalger added this to the Warden 0.10.0 milestone Feb 14, 2021
navarr pushed a commit to wardenenv/images that referenced this pull request Nov 22, 2022
navarr pushed a commit to wardenenv/images that referenced this pull request Nov 22, 2022
navarr pushed a commit to wardenenv/images that referenced this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xdebug 3 support
3 participants