-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xdebug3 support as separate image type #279
Conversation
@davidalger could you check it? |
Looks really good. I'm going to build these and give it a run. Since it's opt-in, I'm not too concerned with it breaking anyone's workflows. Good call on adding a feature flag for it. Perhaps sometime it can be removed and this go Xdebug 3 by default once it's stable and accepted by many. As Xdebug 3 is only available for PHP 7.2+ the image build tooling will need to be updated to only build the xdebug3 variant for 7.2 and higher. I'm working on addressing this now It'd_ be simpler if the images were simply updated to install xdebug3 when php version supports it, but that would require everyone start using it right away, which we don't want here for now. |
Updated the build script so it should pass muster when this is merged (not attempting to build xdebug3 images on older versions of PHP) and then ran this on a local builder:
The following images are now available on docker hub so this can be tested:
Once merged the rest should build via CI. |
Spun up a 2.4.2 sandbox running PHP 7.4, verified requests work and would stop on a breakpoint with and without |
Description
This PR provide support of xdebug3 as separate images that can be configured in
.env
file byPHP_XDEBUG_3=1
directiveRelated Issue
#267