Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modman support for Magento1 #290

Merged
merged 7 commits into from
Feb 14, 2021
Merged

Add modman support for Magento1 #290

merged 7 commits into from
Feb 14, 2021

Conversation

norgeindian
Copy link
Contributor

With this approach it would also be possible to handle modman environments in Magento1.
Solves #253

@sprankhub
Copy link
Contributor

Looks like an easy change. However, IMHO, we could also auto-detect modman-environments. If there is a .modman directory in the Warden root, we have a modman-environment. And in this case, .modman/.basedir already contains the necessary document root. Would IMHO be nicer to auto-detect this and not introduce another setting for this.

@norgeindian
Copy link
Contributor Author

@sprankhub , thanks for the idea.
Adapted my pull request, so modman environments are now automatically detected and handled.
What do you think about this approach?

sprankhub
sprankhub reviewed Feb 12, 2021
View reviewed changes
commands/env.cmd Outdated Show resolved Hide resolved
commands/env.cmd Outdated Show resolved Hide resolved
@sprankhub
Copy link
Contributor

Nice! Let's see what @davidalger says ;-)

davidalger
davidalger reviewed Feb 13, 2021
View reviewed changes
Copy link
Collaborator

@davidalger davidalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a great idea to me. Left a couple comments / nit-picks. Once those are addressed, be happy to merge it. Thanks!

environments/magento1/magento1.base.yml Outdated Show resolved Hide resolved
commands/env.cmd Outdated Show resolved Hide resolved
commands/env.cmd Outdated Show resolved Hide resolved
@davidalger davidalger linked an issue Feb 13, 2021 that may be closed by this pull request
Support .modman environments #253
Closed
@norgeindian
Copy link
Contributor Author

@davidalger , thanks a lot for your comments and suggestions.
I included them, so feel free to merge.

@davidalger davidalger merged commit 9ca1268 into wardenenv:develop Feb 14, 2021
davidalger added a commit that referenced this pull request Feb 14, 2021
@davidalger
Updated CL for #290
899b2d0
@davidalger davidalger added enhancement New feature or request env-magento1 labels Feb 14, 2021
davidalger added a commit that referenced this pull request Feb 14, 2021
@davidalger
Removed automatic resolver configuration attempt on Linux
83a6eb7 
issue #185
issue #251
resolves #290
@davidalger davidalger added this to the Warden 0.10.0 milestone Feb 14, 2021
@norgeindian norgeindian deleted the add-magento1-modman-support branch March 23, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sprankhub sprankhub sprankhub left review comments

@davidalger davidalger davidalger left review comments

Assignees
No one assigned
Labels
enhancement New feature or request env-magento1
Projects
None yet
Milestone
Warden 0.10.0
Development

Successfully merging this pull request may close these issues.

Support .modman environments
3 participants
@norgeindian @sprankhub @davidalger