Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDA topic name assignment doesn't work #294

Closed
asmithh opened this issue Jul 14, 2020 · 3 comments · Fixed by #308
Closed

LDA topic name assignment doesn't work #294

asmithh opened this issue Jul 14, 2020 · 3 comments · Fixed by #308
Labels
bug Something isn't working frontend LDA

Comments

@asmithh
Copy link
Collaborator

asmithh commented Jul 14, 2020

https://drive.google.com/file/d/1lxM102gHQRZZtfUuiTmEkCE7zHdE8dJ8/view?usp=sharing

^ there's a video of the bug in action.

basically once you have a trained LDA model and you open that landing page, the next step would be to enter the names of the topics the model discovered. however, the first time you do that and click submit, nothing happens. if you then click on the button again, no matter how many labels you enter (regardless of whether it is the correct number of labels or not) you get a "you have the wrong number of labels" error message.

This occurs on Chrome on macOS; not sure if this also occurs on other browser/OS combinations.

@asmithh asmithh added bug Something isn't working frontend LDA labels Jul 14, 2020
@dnaaun
Copy link
Owner

dnaaun commented Jul 16, 2020

Hi @lentil-soup , until we start echoing back to the user the error messages the backend gives, I don't think we should concern ourselves with such error messages, because we have no idea what the backend actually said. I vote for closing this until we get the frontend to echo back to the user the error messages the backend gives( #293 )

@asmithh
Copy link
Collaborator Author

asmithh commented Jul 16, 2020 via email

@dnaaun
Copy link
Owner

dnaaun commented Jul 20, 2020

For documentation purposes, I'd like to leave a comment saying that, in addition to #308 which fixed the naming issue, the bug of not being able to download your results that @lentil-soup mentoined in the comments was fixed(barring "other" bugs in the frontend).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend LDA
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants