Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Interest in more sophisticated vagrantfile? #13

Closed
danieldreier opened this issue Feb 17, 2014 · 4 comments
Closed

Interest in more sophisticated vagrantfile? #13

danieldreier opened this issue Feb 17, 2014 · 4 comments

Comments

@danieldreier
Copy link
Contributor

I recently put together a puppet-serf demo. Any interest in me merging that into the Vagrantfile on puppet-serf? I don't want to do a bunch of work if you prefer a very simple vagrant setup to begin with.

@davidcollom
Copy link
Owner

Hi. This has been very much on my to-do list! The current vagrantfile was simply usedfor initial building of the module and ensure services and config compiled correctly.

I know that there's a few pr's for this project and I do intend to review and merge as soon as I've got some free time.

@danieldreier
Copy link
Contributor Author

Awesome! I'll put together a PR based on my previous work.

@danieldreier
Copy link
Contributor Author

PR #14 includes a new Vagrantfile setup based on my puppet-serf demo repo, and also includes the "advertise" parameter PR changes, so I closed PR #12 because PR #14 won't work without advertise.

@danieldreier
Copy link
Contributor Author

Closing because PR #14 is merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants