Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about result #2

Open
ICDI0906 opened this issue Jan 16, 2020 · 14 comments
Open

about result #2

ICDI0906 opened this issue Jan 16, 2020 · 14 comments

Comments

@ICDI0906
Copy link

come again~
I have run your data on my model, but the result is unbelievable. I almost get the same result with the model graph wavenet on public dataset metr-la. But on your dataset PEMS08, I get MAE: 1.57, MAPE: 3.44%, RMSE: 3.73. Your results are MAE 17.13, MAPE 10.96%, RMSE 26.80.
which is much smaller. I have checked my code, but I didn't find any problem. Do you know why? can you tell me your experiment details?

@Davidham3
Copy link
Owner

I don't know why your results looks so wired. As far as I know, graph wavenet does not fit all dataset nicely. I run the experiment in July last year, you should check whether they have updated code, so that the result may be different. Besides, you should also check all datasets not only the PeMS08, and all experiment should be finished ten times, compute the mean and std. I dont think there is any problem in my experiment. In addition, you should compute the mean value of the PEMS08, if the mean value is around 100, do you think the 1.57 is reasonable?

@ICDI0906
Copy link
Author

ICDI0906 commented Jan 16, 2020 via email

@ICDI0906
Copy link
Author

Hello, I run your data using DCRNN model, the MAE is also small. In the experiment, I just change the dataset. Maybe I lose some important steps, I want to know how you do expriment with DCRNN.
thanks~

@CYBruce
Copy link

CYBruce commented Aug 17, 2020

我也感觉论文的结果有点问题,MAPE接近20%对于速度预测来说有点夸张了,会不会是计算的时候哪里出了问题?也许可以用公开的数据集METR-LA试一下

@CYBruce
Copy link

CYBruce commented Aug 17, 2020

Hello, I run your data using DCRNN model, the MAE is also small. In the experiment, I just change the dataset. Maybe I lose some important steps, I want to know how you do expriment with DCRNN.
thanks~

我在许多公开实验集的实验过程中graph wavenet优于DCRNN优于STGCN,但这个实验结果相反

@ICDI0906
Copy link
Author

是的,可能作者没有公开更多的实验细节吧

@estimate123
Copy link

?也许可以用公开的数据集METR-LA试一下

请问下这篇文章不是进行的流量预测吗

@guokan987
Copy link

?也许可以用公开的数据集METR-LA试一下

请问下这篇文章不是进行的流量预测吗

虽然我还没复现这篇文章,但是Graph WaveNet的性能应该是明显好于STGCN(原始)的,不管是在速度还是流量,因为原始的STGCN只有两个block,6层,而Graph WaveNet 可有8个block,至少14层以上,这参数量就不是一个级别的。都是Gated-CNN加GCN。
——。—— lol

@estimate123
Copy link

?也许可以用公开的数据集METR-LA试一下

请问下这篇文章不是进行的流量预测吗

虽然我还没复现这篇文章,但是Graph WaveNet的性能应该是明显好于STGCN(原始)的,不管是在速度还是流量,因为原始的STGCN只有两个block,6层,而Graph WaveNet 可有8个block,至少14层以上,这参数量就不是一个级别的。都是Gated-CNN加GCN。
——。—— lol

请问你复现过ASTGCN那篇文章吗,能复现出论文里的效果吗?我训练那个模型总是过拟合,达不到ASTGCN论文里的效果

@guokan987
Copy link

?也许可以用公开的数据集METR-LA试一下

请问下这篇文章不是进行的流量预测吗

虽然我还没复现这篇文章,但是Graph WaveNet的性能应该是明显好于STGCN(原始)的,不管是在速度还是流量,因为原始的STGCN只有两个block,6层,而Graph WaveNet 可有8个block,至少14层以上,这参数量就不是一个级别的。都是Gated-CNN加GCN。
——。—— lol

请问你复现过ASTGCN那篇文章吗,能复现出论文里的效果吗?我训练那个模型总是过拟合,达不到ASTGCN论文里的效果

我记得好像训练在10-20epochs时,就达到最好的validation的结果。。。。确实有点过拟合。。。。。。效果也差点意思。。。。lol

@estimate123
Copy link

好像训练在10-20epochs时,就达到最好的validation的结果。。。。确实有点过拟合。。。。。。效果也差点意思。。。。lol

是的,可能是ASTGCN模型参数太多了吧

@xingzhinie
Copy link

据我所知,pems数据集中不仅含有flow data还有speed data等,如果误用speed数据的话,mae等评价指标有可能变得很小

@JianSoL
Copy link

JianSoL commented Jun 2, 2022

Graph WaveNet展示的结果是不是有问题,我这边跑的结果比论文中的结果小很多

@guokan987
Copy link

Graph WaveNet展示的结果是不是有问题,我这边跑的结果比论文中的结果小很多

lol,摊手

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants