Fix for margin issue #286
Merged
Fix for margin issue #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 2, 2015 12:28
|
I guess Also I think that, el = typeof el !== 'undefined' ? el : document.body;can be written as just. el = el || document.body;Otherwise looks good. |
|
Okay thanks for the feedback, I'll get those changes made now. |
|
Thanks for you help on this. Released as v3.5.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is hopefully a fix for the margin issue here: #281
Two simple changes are made. getComputedBodyStyle takes an extra parameter to specify the element to check. If nothing is passed, it will fall back to the previous behaviour of using the body element. Additionally, when getMaxElement iterates over its list of elements, the element is passed to getComputedBodyStyle in order to fetch that elements margin.