Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow devTools usage in production #2046

Merged
merged 2 commits into from
Apr 10, 2021

Conversation

SimeonC
Copy link
Contributor

@SimeonC SimeonC commented Mar 29, 2021

Fixes #2020

@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2021

🦋 Changeset detected

Latest commit: d3fb4d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
xstate Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@with-heart with-heart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to specifically call out the inspect-as-documentation use case that initiated the issue discussion somewhere?

Otherwise this lgtm!

@davidkpiano
Copy link
Member

@Andarist Would you consider this a breaking change?

@Andarist
Copy link
Member

@davidkpiano no, I don't think so - as @SimeonC has pointed out in the issue: this doesn't change the behavior that much as it's the inspect that creates the inspector, and not this code here. So it's hard for me to imagine how this could break anyone - it should only allow to setup the inspector in production builds at the expense of few bytes being added to the xstate's bundlesize (but just a few as this tries to call into the inspector API which gets provided through a global).

@davidkpiano davidkpiano merged commit 7325e1a into statelyai:master Apr 10, 2021
This was referenced Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@xstate/inspect should not bail in production
4 participants