Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where always transition not taken in absence of enabled transitions #2343

Merged
merged 5 commits into from
Jun 26, 2021

Conversation

davidkpiano
Copy link
Member

@davidkpiano davidkpiano commented Jun 25, 2021

This PR fixes an issue where, if an event is sent to a machine in a state where it does not accept that event (no enabled transitions), any transient (always) transitions will be ignored. According to the SCXML algorithm (see mainEventLoop), they should not be ignored.

@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2021

🦋 Changeset detected

Latest commit: 1ef29e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

davidkpiano and others added 3 commits June 25, 2021 16:02
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Copy link
Member

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to add a changeset for this - I've merged my PR to this branch so you may want to pull it from origin first.

@davidkpiano davidkpiano merged commit e0d6e2b into main Jun 26, 2021
This was referenced Jun 26, 2021
@Andarist Andarist deleted the davidkpiano/always-no-enabled-transitions branch August 23, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants