refactor(embeddings)!: Change embedDocuments input to List<Document> #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `Embeddings.embedDocuments` method takes a `List<String>` which is not ideal because: 1. It is not consistent with the name of the method 2. Some embedding models allow to pass some metadata to improve the quality of the generated embedding (e.g. VertexAI allows to pass a 'title' property) This PR refactors the method to expect a `List<Document>` instead. Making it more aligned with the method name and allowing to pass metadata to the embedding models.
davidmigloz
added a commit
that referenced
this pull request
Sep 5, 2023
#153) Currently `Embeddings.embedDocuments` method takes a `List<String>` which is not ideal because: 1. It is not consistent with the name of the method 2. Some embedding models allow to pass some metadata to improve the quality of the generated embedding (e.g. VertexAI allows to pass a 'title' property) This PR refactors the method to expect a `List<Document>` instead. Making it more aligned with the method name and allowing to pass metadata to the embedding models.
KennethKnudsen97
pushed a commit
to KennethKnudsen97/langchain_dart
that referenced
this pull request
Sep 29, 2023
davidmigloz#153) Currently `Embeddings.embedDocuments` method takes a `List<String>` which is not ideal because: 1. It is not consistent with the name of the method 2. Some embedding models allow to pass some metadata to improve the quality of the generated embedding (e.g. VertexAI allows to pass a 'title' property) This PR refactors the method to expect a `List<Document>` instead. Making it more aligned with the method name and allowing to pass metadata to the embedding models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Embeddings.embedDocumentsmethod takes aList<String>which is not ideal because:This PR refactors the method to expect a
List<Document>instead. Making it more aligned with the method name and allowing to pass metadata to the embedding models.