-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to download GE-Proton versions 6 or older #387
Comments
Thanks for reporting. ProtonUp-Qt currently only loads the 100 newest compatibility tool releases. It's probably a good idea to add a For now, you need to manually download and install GE-Proton from their releases page: https://github.com/GloriousEggroll/proton-ge-custom/releases Code References for Developers: https://api.github.com/repos/GloriousEggroll/proton-ge-custom/releases?per_page=100 ProtonUp-Qt/pupgui2/resources/ctmods/ctmod_00protonge.py Lines 123 to 128 in f176d57
|
Might also make sense to make the default configurable -for now in the config, in future on a settings screen, along with a place to put the API tokens for GitHub/GitLab, which could complement this "load more" feature quite well |
Hmm, it seems the maximum that GitHub will return is 100 per page. You have to pass the If you have ## Returns "100"
curl --silent --url "https://api.github.com/repos/GloriousEggroll/proton-ge-custom/releases?per_page=100" | jq '. | length'
## Also returns "100"
curl --silent --url "https://api.github.com/repos/GloriousEggroll/proton-ge-custom/releases?per_page=200" | jq '. | length'
## Returns "69" currently
curl --silent --url "https://api.github.com/repos/GloriousEggroll/proton-ge-custom/releases?per_page=100&page=2" | jq '. | length' So in order to accommodate this, we would need to add some logic to filter through multiple pages if the However before implementing, we should consider something: We have a util method for fetching project releases, aptly named EDIT: Having a look again at the code, we probably don't use these functions for the GE-Proton ctmod because, for instance, |
Chiming in to say I would also really like to be able to load more/older versions of Proton. Fingers crossed this will be in a coming update, and I sincerely appreciate your work on ProtonUp-Qt. |
Describe the bug
On the version scroll down menu for GE-Proton, it only goes down far enough for 7.0rc3-GE-1, no GE Protons from 6 or older show on the menu.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Should be able to access all older versions of GE-Proton
Screenshots
Desktop (please complete the following information):
Additional context
Terminal output
The text was updated successfully, but these errors were encountered: