Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further Improvements to datatable function #3

Closed
3 tasks done
davidruvolo51 opened this issue Feb 6, 2020 · 2 comments
Closed
3 tasks done

Further Improvements to datatable function #3

davidruvolo51 opened this issue Feb 6, 2020 · 2 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Comments

@davidruvolo51
Copy link
Owner

davidruvolo51 commented Feb 6, 2020

The following improvements to the datatable are needed.

  • Improve the naming convention of helper functions: this is probably a bit far down the list of "needs", but it is probably better to get this done early. The names of helper functions could be improved to make them more memorable. Rethink the names of the functions and come up with a naming system that could be reused in other component.s
  • Add more options to control the styling of the table output: more options to control the rendering of style (i.e., css attributes) is needed for non-shiny usage. For example, disabling the rendering of classes and injecting the html dependencies altogether. This would be useful if a user needs a simple html table generator
  • Improve the handling of component defaults: the current method is not ideal. Instead, the style and options arguments should passed in through .... A new argument validation function will need to be written. Consider moving the css argument into style. Move documentation for these arguments to a new section
@davidruvolo51 davidruvolo51 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Feb 6, 2020
@davidruvolo51 davidruvolo51 self-assigned this Feb 6, 2020
@davidruvolo51
Copy link
Owner Author

Commit fcba0ac addresses these issues. See pull request for more details

@davidruvolo51
Copy link
Owner Author

Merged in #4. Additional style and options props might be added in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant