Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug mode: write profiling for actual run #175

Closed
vasdommes opened this issue Jan 23, 2024 · 0 comments · Fixed by #215
Closed

Debug mode: write profiling for actual run #175

vasdommes opened this issue Jan 23, 2024 · 0 comments · Fixed by #215
Assignees
@vasdommes
Labels
enhancement
Milestone
3.0.0

Comments

@vasdommes
Copy link
Collaborator

Currently, SDPB writes profiling data only for timing run to ck.profiling/ folder.
Sometimes we want to see the same data for actual run (e.g. to see how well does block mapping work).

To avoid name collision, we can create unique subdirectory (e.g. with current datetime or with incrementing index) inside ck.profiling/ for each run.
@vasdommes vasdommes added this to the Backlog milestone Jan 23, 2024
@vasdommes vasdommes self-assigned this Jan 23, 2024
vasdommes added a commit that referenced this issue Mar 21, 2024
@vasdommes
Fix #175 Debug mode: write profiling for actual run
e9ef502 
After actual run, we write profiling data to ck.profiling/ and block_timings (for the 2nd step) to ck/block_timings
Old data is moved to ck.profiling.0/ (or ck.profiling.1/ etc., if .0 exists) and block_timings.0

Previously, we wrote data only for the timing run.
vasdommes added a commit that referenced this issue Mar 21, 2024
@vasdommes
Fix #175 Debug mode: write profiling for actual run
ae0cf9b 
After actual run, we write profiling data to ck.profiling/ and block_timings (for the last step) to ck/block_timings
Old data is moved to ck.profiling.0/ (or ck.profiling.1/ etc., if .0 exists) and block_timings.0

Previously, we wrote data only for the timing run.
vasdommes added a commit that referenced this issue Mar 21, 2024
@vasdommes
Fix #175 Debug mode: write profiling for actual run
58203b3 
After actual run, we write profiling data to ck.profiling/ and block_timings (for the 2nd step) to ck/block_timings
Old data is moved to ck.profiling.0/ (or ck.profiling.1/ etc., if .0 exists) and block_timings.0

Previously, we wrote data only for the timing run.
vasdommes added a commit that referenced this issue Mar 21, 2024
@vasdommes
Fix #175 Debug mode: write profiling for actual run
522dc98 
After actual run, we write profiling data to ck.profiling/ and block_timings (for the last step) to ck/block_timings
TODO: do not write block_timings if number of iterations == 1?

Old data is moved to ck.profiling.0/ (or ck.profiling.1/ etc., if .0 exists) and block_timings.0

Previously, we wrote data only for the timing run.
@vasdommes vasdommes mentioned this issue Mar 22, 2024
Merged
@vasdommes vasdommes modified the milestones: Backlog, 3.0.0 Mar 22, 2024
vasdommes added a commit that referenced this issue Mar 22, 2024
@vasdommes
Merge pull request #215 from davidsd/misc
d3d0c96 
Fix #175 Debug mode: write profiling for actual run + misc improvements
vasdommes added a commit that referenced this issue Mar 23, 2024
@vasdommes
Skydiving: Fix #175 Debug mode: write profiling for actual run
f954949 
same as in SDPB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vasdommes vasdommes

Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Fix #175 Debug mode: write profiling for actual run + misc improvements davidsd/sdpb
1 participant
@vasdommes