Fix #175 Debug mode: write profiling for actual run + misc improvements #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… WARN WARN is written multiple times, polluting the output See also #202 bigint-syrk-blas: Unit tests fail if FLINT library compiled without BLAS
If we set low default_precision, then test for (a_2 * b_2) fails on Boost 1.66 + MPFR 4.2.1 (passes on Boost 1.74 + MPFR 4.1.0). This happened on BU cluster.
…() and Boost_Float::default_precision()
After actual run, we write profiling data to ck.profiling/ and block_timings (for the last step) to ck/block_timings TODO: do not write block_timings if number of iterations == 1? Old data is moved to ck.profiling.0/ (or ck.profiling.1/ etc., if .0 exists) and block_timings.0 Previously, we wrote data only for the timing run.
|
Example: timing run vs actual run for a large SDP problem (nmax=18, stress-tensors-3d), the same as in #211
|
Typical use case is "A was not numerically HPD" error for some of the blocks due to low precision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After actual run, we write profiling data to
ck.profiling/and block timings (for the last step) tock/block_timings.Old data is moved to
ck.profiling.0/(orck.profiling.1/etc., if.0exists) andblock_timings.0Previously, we wrote data only for the timing run, and it was hard to check actual run and see if it improved.
NB: we do not write
ck/block_timingsif solver exits before completing two iterations.mpfr2mpftests for Boost 1.66 (BU cluster). In this version, precision for Boost_Float expressiona*bwas set to default_precision instead of actual precision ofaandb.Q.syrktimer, measuring the wholesyrk_Q()function (normalize +bigint_syrk_blas()+ restore)Environment::set_precision()function which sets bothEl::gmp::Precision()andBoost_Float::default_precision().Print warning if
--procGranularityis used.Updated Install.md and instructions for MacBook as well as BU, Harvard and Imperial HPC.
A was not numerically HPDdue to low precision).