Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The position filtering methods in BaseMission aren't really valid for survey-type missions #5

Closed
DavidT3 opened this issue Nov 7, 2022 · 1 comment
Closed

The position filtering methods in BaseMission aren't really valid for survey-type missions #5

DavidT3 opened this issue Nov 7, 2022 · 1 comment
Assignees
@DavidT3
Labels
enhancement New feature or request

Comments

@DavidT3
Copy link
Owner

DavidT3 commented Nov 7, 2022

For instance it wouldn't really be valid for eROSITA, because (at least for eFEDS) their data is released in big sweeps across the sky. As such matching to the central coordinate of that region doesn't really have much meaning.
@DavidT3 DavidT3 added the enhancement New feature or request label Nov 7, 2022
@DavidT3 DavidT3 self-assigned this Nov 7, 2022
DavidT3 added a commit that referenced this issue Nov 7, 2022
@DavidT3
Completed the filter_on_positions method, though it isn't super valid…
2a972ab 
… for survey type missions. As such a new issue has been opened to enhance this method in the future, Issue #5
@DavidT3
Copy link
Owner Author

DavidT3 commented Aug 4, 2023

I have sort of mitigated this through issue #112 , though it still isn't really a solution.

It will be slightly less of a problem for eRASS releases, because they will be squares, which means that a distance search is perfectly valid.

@DavidT3 DavidT3 closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavidT3 DavidT3

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavidT3