Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading XMM data should be allowed to retry at least once #55

Open
DavidT3 opened this issue Jan 20, 2023 · 1 comment
Open

Downloading XMM data should be allowed to retry at least once #55

DavidT3 opened this issue Jan 20, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@DavidT3
Copy link
Owner

DavidT3 commented Jan 20, 2023

If the connection is refused, then it should be allowed to attempt at least one more time to download the data.

@DavidT3 DavidT3 self-assigned this Jan 20, 2023
@DavidT3 DavidT3 added the enhancement New feature or request label Jan 20, 2023
@DavidT3
Copy link
Owner Author

DavidT3 commented Jan 25, 2023

There should also be a check for whether a zipped tar remains, because if so then I think something has gone wrong. This did happen as I tested re-processing all of XMM. So I ran a little script:

`import os
from shutil import rmtree

dirs = os.listdir('.')

tars = [f for f in dirs if 'tar.gz' in f]

for tar in tars:
obs_id = tar.split('.')[0]
if obs_id in dirs:
rmtree(obs_id)
os.remove(tar)`

To identify remaining zips, and remove any ObsID directory with the same name.

I think this should probably be a checking step in the DAXA downloading process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant