Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming a source in the standard astronomy style results in spectrum generation issues #13

Closed
DavidT3 opened this issue Jun 18, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@DavidT3
Copy link
Owner

DavidT3 commented Jun 18, 2020

For instance, defining a source with name="XMMXCSJ142601.0+374937.0", results in a SAS error:

xga.exceptions.SASGenerationError: datasetCouldNotBeRead raised by rmfgen - The dataset with name '0112230201_mos1_XMMXCSJ142601.0' could not be read; either it does not exist or it is in an unrecognised format

The dataset name reported in the error is not the full spectrum path, its cut off just before a "+" symbol, suggesting some SAS procedure has an issue with that particular symbol.

The error does not seem to occur when the "+" is replaced by a "-"

@DavidT3 DavidT3 self-assigned this Jun 18, 2020
@DavidT3 DavidT3 added the bug Something isn't working label Jun 18, 2020
@DavidT3
Copy link
Owner Author

DavidT3 commented Jun 18, 2020

  • in filenames has some extra meaning to SAS, so I took a slightly cheesy route and just replaced any "+" symbols in object names with "x", when it comes to writing and reading files. The name of the source object itself is not altered, just the files that SAS generates from it.

@DavidT3 DavidT3 closed this as completed Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant