Issues with @returns instead of @return

[dinbrca]

Hi,

FIRST OF ALL ---- THANK YOU DAVID!

I am using JMS seriallizer with DTS eBay SDK.

I am getting a simple error of

`[Semantical Error] The annotation "@returns" in method DTS\eBaySDK\Types\RepeatableType::offsetExists() was never imported. Did you maybe forget to add a "use" statement for this annotation?

This can be easily fixed by changing @returns to @return.. I found it problematic in dts/ebay-sdk-php/src/Types/RepeatableType.php and in dts/ebay-sdk-php/src/Types/BaseType.php but also found it in dts/ebay-sdk-php/src/Parser/XmlParser.php..

Please change it in your next update, as this is creating an error generated by Doctrine..

Stack Trace:

[1] Doctrine\Common\Annotations\AnnotationException: [Semantical Error] The annotation "@returns" in method DTS\eBaySDK\Types\RepeatableType::offsetExists() was never imported. Did you maybe forget to add a "use" statement for this annotation?
    at n/a
        in C:\wamp\www\DropShipMe\vendor\doctrine\annotations\lib\Doctrine\Common\Annotations\AnnotationException.php line 54

    at Doctrine\Common\Annotations\AnnotationException::semanticalError('The annotation "@returns" in method DTS\eBaySDK\Types\RepeatableType::offsetExists() was never imported. Did you maybe forget to add a "use" statement for this annotation?')
        in C:\wamp\www\DropShipMe\vendor\doctrine\annotations\lib\Doctrine\Common\Annotations\DocParser.php line 703

    at Doctrine\Common\Annotations\DocParser->Annotation()
        in C:\wamp\www\DropShipMe\vendor\doctrine\annotations\lib\Doctrine\Common\Annotations\DocParser.php line 641

    at Doctrine\Common\Annotations\DocParser->Annotations()
        in C:\wamp\www\DropShipMe\vendor\doctrine\annotations\lib\Doctrine\Common\Annotations\DocParser.php line 334

    at Doctrine\Common\Annotations\DocParser->parse('/**
     * Determines if the offset exists in the array.
     *
     * @param integer $offset The array index to check.
     *
     * @returns boolean Returns if the offset exists in the array.
     */', 'method DTS\eBaySDK\Types\RepeatableType::offsetExists()')
        in C:\wamp\www\DropShipMe\vendor\doctrine\annotations\lib\Doctrine\Common\Annotations\AnnotationReader.php line 257

    at Doctrine\Common\Annotations\AnnotationReader->getMethodAnnotations(object(ReflectionMethod))
        in C:\wamp\www\DropShipMe\vendor\doctrine\annotations\lib\Doctrine\Common\Annotations\CachedReader.php line 151

    at Doctrine\Common\Annotations\CachedReader->getMethodAnnotations(object(ReflectionMethod))
        in C:\wamp\www\DropShipMe\vendor\jms\serializer\src\JMS\Serializer\Metadata\Driver\AnnotationDriver.php line 110

    at JMS\Serializer\Metadata\Driver\AnnotationDriver->loadMetadataForClass(object(ReflectionClass))
        in C:\wamp\www\DropShipMe\vendor\jms\metadata\src\Metadata\Driver\DriverChain.php line 38

    at Metadata\Driver\DriverChain->loadMetadataForClass(object(ReflectionClass))
        in C:\wamp\www\DropShipMe\vendor\jms\serializer\src\JMS\Serializer\Metadata\Driver\AbstractDoctrineTypeDriver.php line 80

    at JMS\Serializer\Metadata\Driver\AbstractDoctrineTypeDriver->loadMetadataForClass(object(ReflectionClass))
        in C:\wamp\www\DropShipMe\vendor\jms\metadata\src\Metadata\Driver\LazyLoadingDriver.php line 23

    at Metadata\Driver\LazyLoadingDriver->loadMetadataForClass(object(ReflectionClass))
        in C:\wamp\www\DropShipMe\vendor\jms\metadata\src\Metadata\MetadataFactory.php line 103

    at Metadata\MetadataFactory->getMetadataForClass('DTS\eBaySDK\Types\RepeatableType')
        in C:\wamp\www\DropShipMe\vendor\jms\serializer\src\JMS\Serializer\GraphNavigator.php line 188

    at JMS\Serializer\GraphNavigator->accept(object(RepeatableType), null, object(SerializationContext))
        in C:\wamp\www\DropShipMe\vendor\jms\serializer\src\JMS\Serializer\GenericSerializationVisitor.php line 140

    at JMS\Serializer\GenericSerializationVisitor->visitProperty(object(PropertyMetadata), object(ProductDetails), object(SerializationContext))
        in C:\wamp\www\DropShipMe\vendor\jms\serializer\src\JMS\Serializer\GraphNavigator.php line 235

    at JMS\Serializer\GraphNavigator->accept(object(ProductDetails), null, object(SerializationContext))
        in C:\wamp\www\DropShipMe\vendor\jms\serializer\src\JMS\Serializer\GenericSerializationVisitor.php line 140

    at JMS\Serializer\GenericSerializationVisitor->visitProperty(object(PropertyMetadata), object(Product), object(SerializationContext))
        in C:\wamp\www\DropShipMe\vendor\jms\serializer\src\JMS\Serializer\GraphNavigator.php line 235

    at JMS\Serializer\GraphNavigator->accept(object(Product), null, object(SerializationContext))
        in C:\wamp\www\DropShipMe\vendor\jms\serializer\src\JMS\Serializer\GenericSerializationVisitor.php line 102

    at JMS\Serializer\GenericSerializationVisitor->visitArray(array('data' => object(Product)), array('name' => 'array', 'params' => array()), object(SerializationContext))
        in C:\wamp\www\DropShipMe\vendor\jms\serializer\src\JMS\Serializer\JsonSerializationVisitor.php line 55

    at JMS\Serializer\JsonSerializationVisitor->visitArray(array('data' => object(Product)), array('name' => 'array', 'params' => array()), object(SerializationContext))
        in C:\wamp\www\DropShipMe\vendor\jms\serializer\src\JMS\Serializer\GraphNavigator.php line 129

    at JMS\Serializer\GraphNavigator->accept(array('data' => object(Product)), null, object(SerializationContext))
        in C:\wamp\www\DropShipMe\vendor\jms\serializer\src\JMS\Serializer\Serializer.php line 176

    at JMS\Serializer\Serializer->visit(object(JsonSerializationVisitor), object(SerializationContext), array('data' => object(Product)), 'json')
        in C:\wamp\www\DropShipMe\vendor\jms\serializer\src\JMS\Serializer\Serializer.php line 82

    at JMS\Serializer\Serializer->JMS\Serializer\{closure}(object(JsonSerializationVisitor))
        in  line 

    at call_user_func(object(Closure), object(JsonSerializationVisitor))
        in C:\wamp\www\DropShipMe\vendor\phpoption\phpoption\src\PhpOption\Some.php line 89

    at PhpOption\Some->map(object(Closure))
        in C:\wamp\www\DropShipMe\vendor\jms\serializer\src\JMS\Serializer\Serializer.php line 85

    at JMS\Serializer\Serializer->serialize(array('data' => object(Product)), 'json')
        in C:\wamp\www\DropShipMe\src\ApiBundle\Controller\GrabberController.php line 87

    at ApiBundle\Controller\GrabberController->getProductAction(object(Request), 'ebay', '401074807466')
        in  line 

    at call_user_func_array(array(object(GrabberController), 'getProductAction'), array(object(Request), 'ebay', '401074807466'))
        in C:\wamp\www\DropShipMe\vendor\symfony\symfony\src\Symfony\Component\HttpKernel\HttpKernel.php line 148

    at Symfony\Component\HttpKernel\HttpKernel->handleRaw(object(Request), '1')
        in C:\wamp\www\DropShipMe\vendor\symfony\symfony\src\Symfony\Component\HttpKernel\HttpKernel.php line 66

    at Symfony\Component\HttpKernel\HttpKernel->handle(object(Request), '1', true)
        in C:\wamp\www\DropShipMe\vendor\symfony\symfony\src\Symfony\Component\HttpKernel\Kernel.php line 169

    at Symfony\Component\HttpKernel\Kernel->handle(object(Request))
        in C:\wamp\www\DropShipMe\web\app_dev.php line 31

[davidtsadler]

I'll replace @returns with @return over this weekend so that the changes can be included in the Sophie on Monday.

[dinbrca]

Thanks David, have a great weekend!