fix(builder): define $scope to undefined to fallback on $rootScope

Close #39
davinkevin · Jun 27, 2016 · 967d919 · 967d919
1 parent 8839932
commit 967d919
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/core/builder.js b/core/builder.js
@@ -47,7 +47,7 @@ export default class SubscribeBuilder {
         this.queue = queue;
         this.aCallback = angular.noop;
         this.headers = {};
-        this.scope = {};
+        this.scope = undefined;
         this.json = false;
         this.digest = true;
 

diff --git a/core/builder.spec.js b/core/builder.spec.js
@@ -24,7 +24,7 @@ describe('Builder', () => {
 
     it('should subscribe with default parameters', () => {
         builder.build();
-        expect(ngStomp.subscribe.calls.mostRecent().args).toEqual([firstTopic, angular.noop, {}, {}, false, true])
+        expect(ngStomp.subscribe.calls.mostRecent().args).toEqual([firstTopic, angular.noop, {}, undefined, false, true])
     });
 
     it('should subscribe', () => {
@@ -59,11 +59,11 @@ describe('Builder', () => {
         .connect();
 
         expect(ngStomp.subscribe.calls.argsFor(0)).toEqual([firstTopic, aCallback, headers, $scope, false, true]);
-        expect(ngStomp.subscribe.calls.argsFor(1)).toEqual([secondTopic, angular.noop, {}, {}, false, false]);
+        expect(ngStomp.subscribe.calls.argsFor(1)).toEqual([secondTopic, angular.noop, {}, undefined, false, false]);
 
         expect(unSubscriber.connections).toEqual([
             transformToConnection(firstTopic, aCallback, headers, $scope, false, true, 0),
-            transformToConnection(secondTopic, angular.noop, {}, {}, false, false, 1)
+            transformToConnection(secondTopic, angular.noop, {}, undefined, false, false, 1)
         ]);
     });
 

diff --git a/dist/angular-stomp.js b/dist/angular-stomp.js
diff --git a/dist/angular-stomp.min.js b/dist/angular-stomp.min.js
diff --git a/dist/angular-stomp.min.js.map b/dist/angular-stomp.min.js.map